Set parameters in RevokeTokenRequest and RefreshTokenRequest #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgermishuys
added
the
area/foss/access-token-management
pgermishuys
changed the title
Erwinvandervalk
previously approved these changes
Jan 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #312 by enabling additional custom parameters to be passed through refresh token and revoke token requests. The changes ensure that when users provide custom parameters via UserTokenRequestParameters, those parameters are properly included in the underlying token and revocation requests.
Changes:
- Added support for passing custom parameters in
RefreshTokenRequestandRevokeTokenRequest - Added comprehensive test coverage for both refresh and revoke token scenarios with additional parameters
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| UserTokenManagementTests.cs | Added two new test cases verifying that custom parameters are correctly passed through refresh token and revoke token requests |
| OpenIdConnectUserTokenEndpoint.cs | Modified RefreshAccessTokenAsync and RevokeRefreshTokenAsync methods to include custom parameters from UserTokenRequestParameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
access-token-management/test/AccessTokenManagement.Tests/UserTokenManagementTests.cs
Show resolved
Hide resolved
access-token-management/test/AccessTokenManagement.Tests/UserTokenManagementTests.cs
Show resolved
Hide resolved
access-token-management/test/AccessTokenManagement.Tests/UserTokenManagementTests.cs
Show resolved
Hide resolved
pgermishuys
force-pushed
the
pg/token-management
branch
from
e3d4733 to
fbfe515
Compare
Erwinvandervalk
approved these changes
Jan 20, 2026
pgermishuys
added a commit
that referenced
this pull request
Jan 23, 2026
Set parameters in RevokeTokenRequest and RefreshTokenRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312.
Something to note here and that is if the user adds any of the typed properties in here such as "Scope", "Resource", etc and sets the typed properties, they'll receive an
InvalidOperationExceptionwith "Duplicate parameter: scope" for example.We could strip off the typed properties before we set them, but this might unnecessarily complicated the code for no real benefit.