Size MCQ dialog to primary usable (multi-image clamp) - #33
Merged
Conversation
Dual-monitor defaults were taken from the largest Gdk/xrandr mode, so image MCQs opened at ~72% of 4K and overflowed the laptop eDP. Prefer the pointer's monitor when known, otherwise the smallest connected workarea/geometry; maximize stays compositor-local to the host display. Co-authored-by: Cursor <cursoragent@cursor.com>
Default image-MCQ geometry no longer uses absolute 720×700 floors or a 62% preview that overflows Framework eDP once chrome is counted. Maximize reflows the still to the host panel and restores the prior size reliably. Co-authored-by: Cursor <cursoragent@cursor.com>
DEFAULT_DANGER_ARM_MS had stayed at 4000 on main/sizing after the 1s preference lived only on the unmerged primary-display branch; bring both arms back to 1000ms without touching sizing/maximize. Co-authored-by: Cursor <cursoragent@cursor.com>
Stacked previews each took the full single-image height size_request, so 2–3 stills overflowed Framework eDP. Share one stack budget, scroll inside, and size against the OS primary panel (not pointer/largest). Co-authored-by: Cursor <cursoragent@cursor.com>
ajlennon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
size_requestheight (~50% usable), so 2–3 stacked stills summed past Framework eDP primary.Hosts / platforms touched
Test plan
uv run python scripts/test_dialog_ergonomics.pyuv run python scripts/test_mcq_images.pyask_multiple_choiceafter Reload WindowEnvironment: Ubuntu Wayland, Framework eDP-1 primary 1803×1202 + Samsung DP-2 4K; MCP
--directoryatask-question-mcp-mcq-small-display.Behaviour contract
uvdocs keptAI assistance
Made with Cursor