function optimizations + new testing framework - #58
Merged
Conversation
merge optimizations from fork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version brings several major updates to catch22, primarily comprising optimizations to existing code; note that results have been confirmed to be bitwise equivalent with previous versions. There are no major breaking changes for existing users.
The following functions have been optimized (in each case validated against previous implementations on a range of data to confirm bitwise-equivalent results):
DN_OutlierInclude_p_001_mdrmdDN_OutlierInclude_n_001_mdrmdPD_PeriodicityWang_th0_01FC_LocalSimple_mean1_tauresratSB_TransitionMatrix_3ac_sumdiagcovCO_f1ecacCO_Embed2_Dist_tau_d_expfit_meandiffCO_FirstMin_acSC_FluctAnal_2_rsrangefit_50_1_logi_prop_r1SC_FluctAnal_2_dfa_50_1_2_logi_prop_r1SP_Summaries_welch_rect_area_5_1SP_Summaries_welch_rect_centroidChanged
SC_FluctAnal,PD_PeriodicityWang,FC_LocalSimple,DN_OutlierInclude,and the
fftroutine.testData/: fixtures moved intotestData/basic/andtestData/empirical/, and empirical files renamed (e.g.teste1000ts1.txt->e1000_ts0.txt). External scripts referencing the old paths must be updated.Removed
DN_OutlierInclude_abs_001(declaration anddefinition). This was not one of the 22 canonical
catch22features and wasnot used by any language wrapper. Direct callers linking against this symbol
must migrate.
Fixed
C/DN_OutlierInclude.h(
DN_OUTLIERINCLUDE_ABS_001->DN_OUTLIERINCLUDE_H).