Skip to content

Fix "height" spelling throughout the code #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpaiao merged 1 commit into from
Jan 27, 2026
Merged

Fix "height" spelling throughout the code #426

mpaiao merged 1 commit into from
Jan 27, 2026

Conversation

@mpaiao
Copy link
Contributor

@mpaiao mpaiao commented Jan 8, 2026

Description

This is a cosmetic commit, as it simply replaces hite with height. I do not see any reason for misspelling height throughout the code so I thought we should use the proper spelling instead...

Collaborators

@JessicaNeedham because she did the same in FATES a while back and I liked her idea ;)

Types of changes

  • Hot fix (emergential bug fix to make ED2 run again)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (fix or feature that would cause existing functionality to change)

Changes in Settings, Input Files or Output Files

  • This feature requires changes in ED2IN
  • This feature requires changes in the XML parameter file
  • This feature requires changes in other input files
  • This feature will change output files

Expectation of Answer Changes:

  • No changes expected (bit-for-bit compatibility)
  • Changes expected with specific configurations (see details below)
  • Changes expected in all simulations (see details below)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • ED2 Wiki update:

Testing :

  • All new and existing tests passed.

@mpaiao
This pull request simply fixes the spelling of "height" throughout th…
97889a4 
…e ED2 code. I do not

see a reason to call it "hite"...
@pmoorcroft
Copy link

pmoorcroft commented Jan 9, 2026 via email

@mpaiao
Copy link
Contributor Author

mpaiao commented Jan 10, 2026

@pmoorcroft this is not a critical PR, I just made this one because I was bored waiting for some runs to finish ;), so we can keep the spelling if more people prefer it. Let's see what others think

@pmoorcroft
Copy link

pmoorcroft commented Jan 12, 2026 via email

@mpaiao
Copy link
Contributor Author

mpaiao commented Jan 27, 2026

There was no additional feedback, or anyone with reasons against updating the spelling, so I assume it is fine. I will go ahead and merge it.

@mpaiao mpaiao merged commit 5722229 into EDmodel:master Jan 27, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpaiao @pmoorcroft