Skip to content

Skip tests that require gpus when crosscompiling Siesta #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
laraPPr wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Skip tests that require gpus when crosscompiling Siesta #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8bbcfc
Skip tests that require gpus when crosscompiling Siesta
laraPPr Jun 11, 2026
9c273af
remove test easystack
laraPPr Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion eb_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from easybuild.tools.filetools import apply_regex_substitutions, copy_dir, copy_file, remove_file, symlink, which
from easybuild.tools.modules import get_software_root, get_software_root_env_var_name
from easybuild.tools.run import run_cmd
from easybuild.tools.systemtools import AARCH64, POWER, X86_64, det_parallelism, get_cpu_architecture, get_cpu_features
from easybuild.tools.systemtools import AARCH64, POWER, X86_64, det_parallelism, get_cpu_architecture, get_cpu_features, get_gpu_info
from easybuild.tools.toolchain.compiler import OPTARCH_GENERIC
from easybuild.tools.toolchain.toolchain import is_system_toolchain
from easybuild.tools.version import VERSION as EASYBUILD_VERSION
Expand Down Expand Up @@ -1705,6 +1705,23 @@ def pre_test_hook_ignore_failing_tests_OpenBabel_a64fx(self, *args, **kwargs):
self.cfg['testopts'] = "|| echo ignoring failing tests"


def pre_test_hook_Siesta_ignore_failure_with_crosscompilation(self, *args, **kwargs):
"""
Ignore failing tests when crosscompiling without gpu pressent.
"""
if self.name == 'Siesta':
if self.version in ['5.4.2']:

@boegel boegel Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check for CUDA in self.cfg['versionsuffix']?

We should only skip these tests for CUDA easyconfigs of Siesta

cuda_cc = build_option('cuda_compute_capabilities')
if cuda_cc and not get_gpu_info():
failing_tests=[
"Solvers-si-qdot-elsi-elpa-gpu_mpi4_omp1", # runs cuda get device
"Solvers-si-qdot-elsi-elpa-1stage-gpu_mpi4_omp1", # runs cuda get device
"Solvers-si-qdot-elpa-native-gpu_mpi4_omp1", # runs cuda get device
"Solvers-si-qdot-elpa-native-1stage-gpu_mpi4_omp1", # runs cuda get device
]
self.cfg['testopts'] = self.cfg['testopts'][:-1] + "|" + "|".join(failing_tests) + "'"

@boegel boegel Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're making a lot of assumptions here, maybe it's better to use a regular expression here to keep the part that's already there in the -E '...', and only add to it:

>>> testopts
"--output-on-failure -E 'foo|bar'"
>>>
>>>
>>> re.sub(r"-E '(.*)'", r"-E '\1|one|two'", testopts)
"--output-on-failure -E 'foo|bar|one|two'"



def pre_single_extension_hook(ext, *args, **kwargs):
"""Main pre-extension: trigger custom functions based on software name."""
if ext.name in PRE_SINGLE_EXTENSION_HOOKS:
Expand Down Expand Up @@ -2118,6 +2135,7 @@ def post_easyblock_hook(self, *args, **kwargs):
'Highway': pre_test_hook_exclude_failing_test_Highway,
'LAMMPS': pre_test_hook_lammps_ignore_failure_arm_generic,
'SciPy-bundle': pre_test_hook_ignore_failing_tests_SciPybundle,
'Siesta': pre_test_hook_Siesta_ignore_failure_with_crosscompilation,
'netCDF': pre_test_hook_ignore_failing_tests_netCDF,
'OpenBabel': pre_test_hook_ignore_failing_tests_OpenBabel_a64fx,
'PyTorch': pre_test_hook_increase_max_failed_tests_arm_PyTorch,
Expand Down
1 change: 1 addition & 0 deletions software.eessi.io
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/cvmfs/software.eessi.io

@casparvl casparvl Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file/link supposed to be here...?

@laraPPr laraPPr Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where it came from. I'll fix it but I also need to make updates with Kenneths suggestions so will do it then.

Loading