Closed
Conversation
The wwwroot already ships app.htm directly (BlazorMonaco removal moved the entry point off index.html), so `mv .../index.html .../app.htm` fails with "No such file or directory". Also drops the companion rm of BlazorMonaco static assets since those no longer exist in the publish output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the docs deployment workflow to align with the current Blazor WASM publish output (which now ships app.htm directly) and remove obsolete cleanup steps, fixing a failing deploy step introduced by earlier workflow changes.
Changes:
- Removes the stale
mv .../index.html .../app.htmstep that fails becauseindex.htmlis no longer produced. - Drops removal of
BlazorMonacostatic assets that no longer exist in the publish output. - Keeps the base-href rewrite targeting
app.htmfor GitHub Pages hosting under/ExpressiveSharp/_playground/.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #32 got the publish step working but the next step failed:
The wwwroot already ships `app.htm` directly (BlazorMonaco removal moved the entry point off `index.html`), so the `mv` is obsolete. Also drops the `rm -rf BlazorMonaco` line that was cleaning up static assets that no longer exist in the publish output.
Locally verified `dotnet publish src/Docs/Playground.Wasm -c Release` emits `wwwroot/app.htm` and `` — the remaining `sed` step still has the right target.
Test plan
🤖 Generated with Claude Code