Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the goal to make most datasets and datatypes immutable (or 'frozen'), in preparation for hashing, caching and provenance tracking.
The DataContainer including its subclasses EITData, ContinuousData, IntervalData and SparseData are now frozen.
They all get the method
update(**kwargs)which creates a copy with some attributes replaced.Arrays that are a part of any of these objects are made unwriteable. Most arrays are put in a memoryview, which makes it impossible to ever write to them again. If the array contains objects this is not possible; then the WRITEABLE flag is set to False. This is not 100% save, but should be enough to make sure nobody changes it by accident.
Not all features have been adapted. The features requiring PixelBreath have not been updated. PixelBreath will be updated before this PR is finalized.