Adding figures of Bock and Lauer (2024)

[LisaBock]

Description

In this PR we add the figures of Bock and Lauer, 2024

Fig. 3: Geographical maps of cloud properties
Fig. 4: Geographical maps of net cloud radiative effect
Fig. 6: Zonal averages of cloud properties and their relative projected changes
Fig. 7: Boxplots of relative changes in projected cloud properties

Note: In Figure 3 only the total cloud fraction is included and liquid and ice water path are commented out. The reason is a different standard name of these two variables in CMIP5 and CMIP6 which doesn't allow a computation of the multi model mean by the preprocessor. Iris is working on a solution of the problem: SciTools/iris#5313 (review)

• Closes Adding figures of Bock and Lauer (2024) #3525
• Link to documentation: https://esmvaltool--3526.org.readthedocs.build/en/3526/recipes/recipe_bock24acp.html

---

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Documentation is available
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

• 🧪 Recipe runs successfully
• 🧪 Recipe is well documented
• 🧪 Figure(s) and data look as expected from literature
• 🛠 Provenance information has been added

[LisaBock]

Thank you so much @schlunma for the review!

I tried my best regarding the codacy issues. Could we leave it like that?

[LisaBock]

Thanks @schlunma for reviewing!
I changed the line about the ancestor files in the other two diagnostic scripts as well. Hopefully, it's all fine now.

[schlunma]

I still get the "invalid ancestor" error from clouds/clouds_ecs_groups_maps.py:

log.txt

[schlunma]

Ah, and there is a WARNING Could not write HTML report: Some tags in the recipe could not be resolved: syntax error in line 13: premature end of file which prevents the index.html file to be written (which we need to get a nice overview of the results).

I am not quite sure what the problem is, I guess it's either a recipe problem (this warning appears in all 3 recipes) or a syntax error in the bibtex file you added (esmvaltool/references/bock24acp.bibtex).

[LisaBock]

Hi @schlunma , both issues should be solved now. In my tests, there are no warnings anymore.

[schlunma]

Thanks Lisa, looks good now! All recipes ran successful and their output looks good 🚀

[k-a-webb]

Is there a shape file available for recipe_bock24acp_fig7_boxplots.yml that should have been added to ESMValCore?

ESMValTool/esmvaltool/recipes/clouds/recipe_bock24acp_fig7_boxplots.yml

Line 216 in 5294af4

shapefile: shapefiles/sc_regions.shp

I would have expected to find it here?
https://github.com/ESMValGroup/ESMValCore/tree/main/esmvalcore/preprocessor/shapefiles

[axel-lauer]

The shapefile can be found on Levante in our data pool at ESMValTool2/AUX/shapefiles. I don't think there is a policy yet where shapefiles for recipes should be put.