Skip to content

Fix desktop authorized evolution proposal execution#111

Draft
cursor[bot] wants to merge 4 commits into
mainfrom
cursor/critical-bug-investigation-4841
Draft

Fix desktop authorized evolution proposal execution#111
cursor[bot] wants to merge 4 commits into
mainfrom
cursor/critical-bug-investigation-4841

Conversation

@cursor

@cursor cursor Bot commented Jul 6, 2026

Copy link
Copy Markdown

Summary

  • Fixes a critical desktop evolution bug where authorizing a capability proposal could leave that proposal queued while a background forced run executed an unrelated proposal.
  • Root cause: the desktop authorization path passed the captured proposal_id only through SKILLLITE_EVO_FORCE_PROPOSAL_ID, but skilllite evolution run clears that env var when --proposal-id is not present.
  • Fix: pass --proposal-id <proposal_id> in the desktop background run args and update the regression test to assert both workspace and proposal id are included.

Task Linkage

  • Task ID: TASK-2026-070
  • Task folder: tasks/TASK-2026-070-critical-bug-sweep-2026-07-06/

Injected Specs

  • spec/architecture-boundaries.md (reviewed; no dependency/layering change)
  • spec/security-nonnegotiables.md (not directly applicable; no sandbox/security policy change)
  • spec/testing-policy.md (required for code change)
  • spec/docs-sync.md (reviewed; no docs needed because existing CLI flag semantics are reused)
  • Additional injected specs: spec/verification-integrity.md, spec/task-artifact-language.md, spec/structured-signal-first.md, spec/capability-gap-evolution.md, spec/rust-conventions.md

Validation Evidence

  • Commands executed:
    • git log --oneline --decorate -n 20
    • rustfmt --check --edition 2021 crates/skilllite-assistant/src-tauri/src/skilllite_bridge/integrations/evolution_ui/authorize.rs
    • python3 scripts/validate_tasks.py
    • cargo test --manifest-path crates/skilllite-assistant/src-tauri/Cargo.toml authorized_run_args_include_target_workspace_and_proposal
    • cargo clippy --all-targets -- -D warnings
    • cargo test
  • Key results:
    • Changed-file rustfmt: passed.
    • Task validation: Task validation passed (70 task directories checked).
    • Targeted Tauri test: authorized_run_args_include_target_workspace_and_proposal ... ok (1 passed).
    • Workspace clippy: passed.
    • Workspace tests: passed.
    • Note: full cargo fmt --check --manifest-path crates/skilllite-assistant/src-tauri/Cargo.toml reports unrelated pre-existing formatting diffs across excluded Tauri files; changed file was checked directly.

Regression Scope

  • Areas likely affected:
    • Desktop user-authorized capability evolution background execution.
  • Explicit non-goals:
    • Refactoring cmd_run env cleanup semantics.
    • Broad Tauri formatting cleanup.
    • Changing CLI flags, docs, or user command syntax.

Docs Sync (EN/ZH)

  • Not needed
  • Updated EN + ZH docs
  • Files:
    • N/A; no user-visible CLI/env/docs semantics changed.

Review Checklist

  • Acceptance criteria in tasks/TASK-2026-070-critical-bug-sweep-2026-07-06/TASK.md satisfied (or explicitly deferred)
  • tasks/TASK-2026-070-critical-bug-sweep-2026-07-06/STATUS.md updated with latest progress
  • tasks/TASK-2026-070-critical-bug-sweep-2026-07-06/REVIEW.md includes merge readiness decision
  • tasks/board.md status is up to date
Open in Web View Automation 

cursoragent and others added 4 commits July 6, 2026 11:07
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant