Fix desktop authorized evolution proposal execution#111
Draft
cursor[bot] wants to merge 4 commits into
Draft
Conversation
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proposal_idonly throughSKILLLITE_EVO_FORCE_PROPOSAL_ID, butskilllite evolution runclears that env var when--proposal-idis not present.--proposal-id <proposal_id>in the desktop background run args and update the regression test to assert both workspace and proposal id are included.Task Linkage
TASK-2026-070tasks/TASK-2026-070-critical-bug-sweep-2026-07-06/Injected Specs
spec/architecture-boundaries.md(reviewed; no dependency/layering change)spec/security-nonnegotiables.md(not directly applicable; no sandbox/security policy change)spec/testing-policy.md(required for code change)spec/docs-sync.md(reviewed; no docs needed because existing CLI flag semantics are reused)spec/verification-integrity.md,spec/task-artifact-language.md,spec/structured-signal-first.md,spec/capability-gap-evolution.md,spec/rust-conventions.mdValidation Evidence
git log --oneline --decorate -n 20rustfmt --check --edition 2021 crates/skilllite-assistant/src-tauri/src/skilllite_bridge/integrations/evolution_ui/authorize.rspython3 scripts/validate_tasks.pycargo test --manifest-path crates/skilllite-assistant/src-tauri/Cargo.toml authorized_run_args_include_target_workspace_and_proposalcargo clippy --all-targets -- -D warningscargo testTask validation passed (70 task directories checked).authorized_run_args_include_target_workspace_and_proposal ... ok(1 passed).cargo fmt --check --manifest-path crates/skilllite-assistant/src-tauri/Cargo.tomlreports unrelated pre-existing formatting diffs across excluded Tauri files; changed file was checked directly.Regression Scope
cmd_runenv cleanup semantics.Docs Sync (EN/ZH)
Review Checklist
tasks/TASK-2026-070-critical-bug-sweep-2026-07-06/TASK.mdsatisfied (or explicitly deferred)tasks/TASK-2026-070-critical-bug-sweep-2026-07-06/STATUS.mdupdated with latest progresstasks/TASK-2026-070-critical-bug-sweep-2026-07-06/REVIEW.mdincludes merge readiness decisiontasks/board.mdstatus is up to date