fix(assistant): pass workspace to life pulse rhythm#115
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skilllite schedule tickwithout forwarding that workspace.--workspace <active workspace>to the rhythm subprocess, with a focused unit test for the argument shape.Task Linkage
TASK-2026-070tasks/TASK-2026-070-life-pulse-rhythm-workspace/Injected Specs
spec/architecture-boundaries.md(if architecture/layering changed)spec/security-nonnegotiables.md(if sandbox/security changed)spec/testing-policy.md(required for any code change)spec/docs-sync.md(if behavior/docs/env/commands changed)Validation Evidence
cargo fmt --check && python3 scripts/validate_tasks.pyrustup update stable && rustup default stablesudo apt-get update && sudo apt-get install -y libgtk-3-dev libsoup-3.0-dev libwebkit2gtk-4.1-dev libayatana-appindicator3-dev librsvg2-devcd crates/skilllite-assistant && npm ci && npm run buildcargo test --manifest-path crates/skilllite-assistant/src-tauri/Cargo.toml life_pulse::testscargo testcargo clippy --manifest-path crates/skilllite-assistant/src-tauri/Cargo.toml --all-targets -- -D warningscargo clippy --all-targets -- -D warningsTask validation passed (70 task directories checked).2 passed; 0 failed; 52 filtered out.cargo testpassed with exit code 0.sort_bysuggestions andcrates/skilllite-core/src/config/schema.rs:313manual_filterunder Rust 1.97.Regression Scope
crates/skilllite-assistant/src-tauri/src/life_pulse.rsschedule ticksemantics or flags.Docs Sync (EN/ZH)
Review Checklist
tasks/TASK-2026-070-life-pulse-rhythm-workspace/TASK.mdsatisfied (or explicitly deferred)tasks/TASK-2026-070-life-pulse-rhythm-workspace/STATUS.mdupdated with latest progresstasks/TASK-2026-070-life-pulse-rhythm-workspace/REVIEW.mdincludes merge readiness decisiontasks/board.mdstatus is up to date