Repository navigation
chore: drop Python 3.10, add 3.15, and fix lint broken by ruff 0.16 - #48
Merged
Merged
Conversation
CI on master started failing with 129 ruff errors without any code change. The lint env installs ruff unpinned and pyproject.toml never set `select`, so the rule set was ruff's defaults; ruff 0.16 (2026-07-23) expanded those defaults. Pin `select` to the previous defaults (E4, E7, E9, F) so ruff upgrades can no longer change the rule set. The latest mypy (2.4.0) also flagged `response` in `do_get()` being assigned both CachedResponse and requests.Response; annotate it as requests.Response. Python 3.10 reached end-of-life in October 2026. Require 3.11+, move CI to 3.11, and add 3.15 to the test matrix and classifiers. Drop the 'Z' suffix workaround in `_parse_conference_date()`, since `datetime.fromisoformat()` handles it natively from 3.11. Bump version to 3.0.0 (breaking: minimum Python version). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the red CI on
masterand updates the supported Python range.Why CI broke
hatch run lint:allstarted failing onmaster(run 39155068553) with 129 ruff errors, with no code change. #46 touched onlyrelease.yml, which this workflow doesn't run.ruff>=0.0.166), and[tool.ruff.lint]never setselect, so the rule set was whatever ruff ships as defaults.Fix: pin
select = ["E4", "E7", "E9", "F"], the previous defaults, so future ruff upgrades can't change the rule set.The latest mypy (2.4.0) also reported a real type error that CI hadn't reached yet:
responseindo_get()is assigned bothCachedResponseandrequests.Response. It now has arequests.Responseannotation.Python versions
requires-python = ">= 3.11", and CI's lint/coverage job moves to 3.11.Z-suffix workaround in_parse_conference_date().datetime.fromisoformat()handlesZnatively from 3.11, and the existing test still covers it.3.0.0with a2026-10-18CHANGELOG entry, following Drop Python 3.8 and 3.9 support, require 3.10+ #42.Test plan
pyteston 3.11, 3.12, 3.13, 3.14, 3.15: 89 passed eachhatch run all:test(container matrix, incl.python:3.15image): all pass locally🤖 Generated with Claude Code
Summary by CodeRabbit