Open
Conversation
Also the "disable rounding of windows" flag was lost when leaving fullscreen mode. Fixed this also for SDL2
The saveFS is undefined and I have no idea why this ever worked. Probably emscripten being more strict now.
Not needed anymore
Member
Author
|
Also added some fixes for emscripten now. Though I would stick to SDL2 for now. SDL3 currently overwrites the canvas size with the one from There is a pending PR which appears to improve this behaviour. So will likely be fixed with 3.6 libsdl-org/SDL#14690 The pre/post.js fixes are required by a new emscripten version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also the "disable rounding of windows" flag was lost when leaving fullscreen mode.
Fixed this also for SDL2