This repository was archived by the owner on Feb 1, 2024. It is now read-only.
Allow gzip responses from MailChimp through DecompressingHttpClient#33
Open
snappieT wants to merge 2 commits intoEcwid:masterfrom
snappieT:gzip
Open
Allow gzip responses from MailChimp through DecompressingHttpClient#33snappieT wants to merge 2 commits intoEcwid:masterfrom snappieT:gzip
snappieT wants to merge 2 commits intoEcwid:masterfrom
snappieT:gzip
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've started to get gzipped responses from MailChimp in certain error cases, but the Apache HttpClient doesn't decompress the response before calling
EntityUtils.toString. This resulted in a garbage string that later caused JSON parsing errors:This change ensures that GZipped responses are properly decompressed before reading the response content. I've verified this change no longer causes the above exception.
@basiliscus