Add EdgeContextOptions.apiSigner for native HMAC delegation - #739
Open
paullinator wants to merge 2 commits into
Open
Add EdgeContextOptions.apiSigner for native HMAC delegation#739paullinator wants to merge 2 commits into
paullinator wants to merge 2 commits into
Conversation
6 tasks
paullinator
force-pushed
the
paul/nativeHmacApiSigner
branch
2 times, most recently
from
August 31, 2026 23:52
c87a26a to
3d3fcba
Compare
`waitForPlugins` now waits only for plugin loading to settle, instead of also requiring every plugin named in `EdgeContextOptions.plugins` to have registered successfully. A plugin factory that throws is already caught in `watchPlugins`, which logs the error and omits that one plugin. Requiring the full set on top of that made a single unusable plugin fatal for the entire app: the account pixie awaits `waitForPlugins` before any account can load, so the error became `ACCOUNT_LOAD_FAILED` and every login for every user rejected, whether or not that user held wallets for the affected chain. An API key missing from a plugin's `initOptions` was enough to do it. A plugin that fails to load is now simply absent from `currencyConfig` and `swapConfig`, which is what those maps already document. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
paullinator
force-pushed
the
paul/nativeHmacApiSigner
branch
from
August 31, 2026 23:56
3d3fcba to
8668e5e
Compare
paullinator
marked this pull request as ready for review
September 1, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
Description
Adds
EdgeContextOptions.apiSignerso native code can sign Edge API HMAC requests instead of holdingapiSecretin the JS bundle. GUI uses this for the native HMAC signer; JSapiKey/apiSecretremain a fallback.