Skip to content

Fix wallet row a11y role and token search testID - #6182

Open
j0ntz wants to merge 1 commit into
developfrom
jon/fix/manage-tokens-testid-selectors
Open

Fix wallet row a11y role and token search testID#6182
j0ntz wants to merge 1 commit into
developfrom
jon/fix/manage-tokens-testid-selectors

Conversation

@j0ntz

@j0ntz j0ntz commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Description

Follow-up to #6170, which merged before its Cursor Bugbot findings could be gated. Two of them are real.

FilledTextInput derives its clear control's testID as `${testID}.clearIcon`, so the testID="manageTokensSearch" that #6170 added to the Manage Tokens search field renamed that control from the accidental undefined.clearIcon to manageTokensSearch.clearIcon. The C000045 Add/Edit Tokens maestro flow taps undefined.clearIcon on that exact scene to clear the search field, so it can no longer clear it. This updates that one selector. The flow's other undefined.clearIcon taps are unaffected: C000045's remaining two target the Add Custom Token modal's contract-address input, and the rename-modal and "Search Wallets" picker taps in the other flows use inputs that #6170 never touched.

The wallet list row's new wrapper View also carried the same testID as the EdgeCard inside it, and had no role. EdgeCard forces accessible={false} on its touchable, so only the wrapper's testID reaches XCUITest and the card's copy was dead weight. The wrapper now declares accessibilityRole="button", so a screen reader announces the row as something to activate rather than as an inert group.

Asana: https://app.asana.com/0/1215088146871429/1217587221308437

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Low Risk
Small accessibility and E2E selector fixes with no auth, payment, or data-handling changes.

Overview
Follow-up fixes from Manage Tokens search testID work: the clear control is now manageTokensSearch.clearIcon, so the C000045 Maestro flow taps that id instead of the stale undefined.clearIcon when clearing the search field.

On wallet list rows, the outer wrapper gets accessibilityRole="button" so VoiceOver/TalkBack treat the row as activatable. The touchable EdgeCard stays non-accessible, and the duplicate testID on the card is removed so automation still targets the wrapper.

Reviewed by Cursor Bugbot for commit 97d4b62. Bugbot is set up for automated code reviews on this repo. Configure here.

@j0ntz
j0ntz marked this pull request as ready for review August 28, 2026 23:35
@j0ntz
j0ntz force-pushed the jon/fix/manage-tokens-testid-selectors branch from 45af9be to 97d4b62 Compare August 28, 2026 23:35
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@j0ntz

j0ntz commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence (in-app, iOS sim)

manage tokens clear icon testid

manage tokens clear icon testid

Captured by the agent's in-app test run (build-and-test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant