Fix/model handling in catalog#493
Merged
Merged
Conversation
✅ Deploy Preview for flowfile-wasm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to artifact and namespace resolution, enhances error handling for ambiguous lookups, and improves artifact serialization to reflect missing blobs. It also updates developer documentation to clarify versioning and compatibility contracts. The main themes are: improved error handling for ambiguous artifact/namespace lookups, enhanced artifact serialization, and better developer documentation.
Ambiguity Handling and Resolution:
AmbiguousArtifactErrorandAmbiguousNamespaceErrorexceptions, raised when an artifact or namespace name matches multiple candidates and no unique identifier is provided. This ensures that ambiguous lookups are detected and surfaced to the API caller, requiring explicit disambiguation. [1] [2]get_artifact_by_name,get_artifact_with_versions,delete_all_versions) to assert unambiguous lookups and raise the new exceptions when necessary. [1] [2] [3]resolve_namespace_idto resolve a namespace name to its unique ID, raisingAmbiguousNamespaceErrororNamespaceNotFoundErroras appropriate.namespace_idornamespace(name), and to handle the new ambiguity exceptions by returning HTTP 409 Conflict responses. [1] [2] [3] [4]Artifact Serialization and Blob Existence:
artifact_to_out) and added abulk_enrich_artifactshelper to include ablob_existsflag, indicating whether the artifact's backing blob is present on disk (for filesystem storage). This helps surface missing artifact data to the frontend and users. [1] [2] [3]bulk_enrich_artifactswhen serializing artifact lists, ensuring theblob_existsfield is populated throughout the API. [1] [2] [3]Developer Experience and Documentation:
Other Improvements:
polars-dsto the list of kernel flavours, reflecting its use in the kernel image.