Fix published pre-response handler types#6433
Draft
coyaSONG wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 7909a17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mikearnaldi
reviewed
Jul 17, 2026
| /** @internal */ | ||
| export const requestPreResponseHandlers = new WeakMap<object, PreResponseHandler>() | ||
|
|
||
| /** @internal */ |
Member
There was a problem hiding this comment.
we should not remove internal annotations from exports in the internal folder, we should instead annotate with the type the public re-export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Preserve
appendPreResponseHandlerUnsafein release declaration output.HttpEffectpublicly re-exports this function, but its implementation declaration was tagged@internal. Release builds enablestripInternal, so the symbol disappeared frominternal/preResponseHandler.d.tswhileHttpEffect.d.tsstill imported and re-exported it. Consumers using strict library checking then received TS2305.This change removes the erroneous internal marker, extends the existing lint rule to flag public named re-exports of
@internalsymbols, adds regression coverage, and includes a patch changeset.Validation:
pnpm lint-fixpnpm --dir packages/tools/oxc test --run(51 tests)pnpm vitest run packages/effect/test/unstable/http/HttpEffect.test.ts(17 tests)pnpm check--stripInternal true(the internal file now declaresappendPreResponseHandlerUnsafeinstead of emittingexport {})Prepared with OpenAI Codex assistance; repository guidance, scope, diff, and validation results were checked before publication.
Related