Reject unknown properties in Match.when object patterns#6436
Draft
coyaSONG wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: db1bbb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IMax153
added
the
3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Match.wheninferred object patterns through a generic parameter, which bypassed TypeScript's fresh-object excess-property check. A stale property could therefore keep compiling after the matched value type renamed that property, even though the branch could no longer match at runtime.This adds an object-pattern key guard that accepts keys present on any object variant of the matched input while leaving predicates, refinements, and array patterns unchanged. The regression test covers the reported nullable tagged-union case.
Related
Validation
pnpm test-types Match.tst.ts— 32 tests, 97 assertions, and 11 expected diagnostics passedpnpm test packages/effect/test/Match.test.ts— 62 tests passedpnpm lint-fixpnpm lintpnpm checkpnpm buildpnpm docgen; the affectedpackages/effectdocgen was rerun on the final sourcegit diff --checkAI assistance
OpenAI Codex assisted with issue screening, implementation, and validation. No human review is claimed.