Fix asyncPush bounded buffer termination#6439
Draft
coyaSONG wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 8aae878 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tim-smart
reviewed
Jul 16, 2026
| switch (options?.strategy) { | ||
| case "sliding": | ||
| return Queue.sliding(options.bufferSize ?? 16) | ||
| return Queue.sliding((options.bufferSize ?? 16) + 1) |
Contributor
There was a problem hiding this comment.
I'm pretty sure this just delays the problem rather than fixing it
IMax153
added
the
3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Stream.asyncPushcan synchronously offer both a buffered element and a termination signal before the stream starts consuming the queue. With a bounded dropping or sliding queue sized exactly to the configured buffer, the termination signal can be lost and the stream waits indefinitely.This change reserves one additional queue slot for termination, and adds regression coverage for both bounded strategies. The
effectpackage also receives a patch changeset.Validation:
pnpm test packages/effect/test/Stream/async.test.ts(22 tests passed)pnpm lint-fixpnpm checkpnpm buildpnpm docgengit diff --checkCodex was used to investigate, implement, and validate this change. The exact validation commands and results are listed above.
Related
Stream.asyncPushhangs when using bounded dropping/sliding buffers with synchronous emission #6232Stream.asyncPushhangs when using bounded dropping/sliding buffers with synchronous emission #6232