Include socket details in RpcClient errors#6445
Draft
coyaSONG wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: b9b482a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IMax153
added
the
3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
RpcClient.makeProtocolSocketcurrently replaces every socket failure with the hardcoded messageError in socket, even though it has already extracted the typedSocketErrorfrom the cause.Use the socket error's existing human-readable message when a typed failure is available, while retaining the generic fallback for causes without a socket failure. This surfaces details such as close codes and close reasons without changing the structured
RpcClientErrorshape or its cause.Add a regression test that drives the socket protocol with a
SocketCloseErrorand verifies both the detailed message and preserved cause.Validation:
pnpm lint-fixpnpm test packages/rpc/test/RpcClient.test.ts --runpnpm checkpnpm buildpnpm docgenRelated