fix(sql-drizzle): support SQLite batches#6446
Draft
coyaSONG wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: aabb49b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IMax153
added
the
3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
The SQLite Drizzle integration supplied only Drizzle's single-query callback. As a result,
db.batch()attempted to call an undefined batch callback and failed withTypeError: this.batchCLient is not a function.This change supplies an ordered batch callback to both SQLite constructors. Each query is executed through the existing Effect SQL callback, preserving query order and the existing result mapping. A regression test covers an insert followed by a select in one batch.
Impact
SQLite-backed
@effect/sql-drizzleusers can usedb.batch()without the runtime failure.Related
Validation
corepack pnpm --filter @effect/sql-drizzle test -- --run test/Sqlite.test.ts(13 tests passed)corepack pnpm lint-fixcorepack pnpm checkcorepack pnpm buildcorepack pnpm docgen