Support uncommon HTTP methods#6449
Draft
coyaSONG wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: dab2530 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IMax153
added
the
3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Add the uncommon HTTP methods supported by Fastify, including WebDAV methods such as
PROPFIND,PROPPATCH, andMKCOL, toHttpMethod.This also:
HttpMethodtype inHttpLayerRouterinstead of repeating a narrower method unionAiError.HttpRequestDetailsin sync withHttpMethod.allTRACEas a no-body method@effect/platformand@effect/aiThe change allows DAV and other uncommon-method endpoints to be represented without casts while keeping dependent schemas aligned with the platform method set.
Validation
HttpMethodregression test first and confirmed it failed before the implementation.corepack pnpm test packages/platform/test/HttpMethod.test.ts packages/platform/test/HttpLayerRouter.test.ts packages/ai/ai/test/AiError.test.ts(6 tests passed)corepack pnpm lint-fixcorepack pnpm checkcorepack pnpm buildcorepack pnpm docgencorepack pnpm changeset statusRelated
AI disclosure
This pull request was prepared with Codex assistance. It has not yet received independent human review.