🎨 Palette: Improve accessibility of dynamic output regions#3603
🎨 Palette: Improve accessibility of dynamic output regions#3603EffortlessSteven wants to merge 1 commit intomainfrom
Conversation
💡 What: Replaced invalid `<label>` tags with styled `<div>` elements linked via `aria-labelledby` for scrollable, non-interactive output containers (`<div class="output">` and `<div class="streaming-output">`). Added `tabindex="0"`, `role="region"`, and `aria-live="polite"` to the containers. 🎯 Why: `<label>` elements are strictly meant for form controls. Using them to label generic `<div>` containers violates HTML semantics and causes screen reader issues. Additionally, dynamic AI output regions were not marked as live regions, meaning screen readers wouldn't announce generated text updates. Adding `tabindex="0"` ensures keyboard users can scroll through long output blocks. 📸 Before/After: Before: Output regions were visually labeled with `<label>` but lacked keyboard focusability, proper semantic labeling, and live region updates. After: Output regions use semantically correct ARIA labels, are keyboard accessible, and announce content updates via `aria-live="polite"`. ♿ Accessibility: - Replaced `<label>` with `<div id="...">` + `aria-labelledby` - Added `role="region"` for landmark identification - Added `tabindex="0"` for keyboard scrolling - Added `aria-live="polite"` to announce dynamically generated text (Streaming, Web Worker, Benchmark results)
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What:
Replaced invalid
<label>tags with styled<div>elements linked viaaria-labelledbyfor scrollable, non-interactive output containers (<div class="output">and<div class="streaming-output">). Addedtabindex="0",role="region", andaria-live="polite"to the containers.🎯 Why:
<label>elements are strictly meant for form controls. Using them to label generic<div>containers violates HTML semantics and causes screen reader issues. Additionally, dynamic AI output regions were not marked as live regions, meaning screen readers wouldn't announce generated text updates. Addingtabindex="0"ensures keyboard users can scroll through long output blocks.📸 Before/After:
Before: Output regions were visually labeled with
<label>but lacked keyboard focusability, proper semantic labeling, and live region updates.After: Output regions use semantically correct ARIA labels, are keyboard accessible, and announce content updates via
aria-live="polite".♿ Accessibility:
<label>with<div id="...">+aria-labelledbyrole="region"for landmark identificationtabindex="0"for keyboard scrollingaria-live="polite"to announce dynamically generated text (Streaming, Web Worker, Benchmark results)PR created automatically by Jules for task 8884309839445239076 started by @EffortlessSteven