Introduce Effortless Metrics Clippy policy, policy ledgers, no‑panic allowlists, and xtask gate; bump MSRV to 1.93#3712
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (106)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦀 Cross-Validation SummaryDate: $(date -u +%Y-%m-%d %H:%M:%S UTC) Status Checks
Cross-Validation Lanes
Key Findings
ArtifactsCross-validation receipts and parity reports available for 30 days. Generated by bitnet-rs Cross-Validation Workflow |
1 participant
Motivation
xtaskgate so CI can validate lint inheritance, planned flips, and allowlist/debt metadata.Description
1.93and added[lints] workspace = trueto the root and workspace member manifests so members inherit the policy.workspace.lints.rustandworkspace.lints.clippyinCargo.toml(panic/silent‑failure/UTF‑8/suppression governance and many targeted lints).policy/clippy-lints.toml(msrv + planned 1.94/1.95 flips),policy/clippy-debt.toml(debt template),policy/no-panic-allowlist.tomlandpolicy/non-rust-allowlist.toml(TOML allowlist templates), and a minimalclippy.tomlreserved for repo-specific disallowed items.docs/CLIPPY_POLICY.mddescribing operational rules, suppression style (#[expect(..., reason = "...")]), and ledger/allowlist usage.cargo xtask check-lint-policy(wired intoxtaskCLI) which parses the rootCargo.tomlandpolicy/*files and enforces: MSRV match, workspace lint inheritance, presence/absence of test carveouts, planned flips not active before MSRV bump, debt metadata fields, and allowlist metadata/expiry checks.Cargo.tomlfiles to add lint inheritance and MSRV alignment, and created a repoclippy.tomlwith MSRV and retained complexity thresholds.Testing
cargo run -p xtask --no-default-features -- check-lint-policy(builtxtaskwith CPU features) and the new gate completed successfully:✅ lint policy check passed.cargo fmt --all -- --checkand formatting checks passed.xtaskvariations to iterate on the gate implementation; full workspace builds that exercise GPU/CUDA features produced linker errors in this environment due to missing system CUDA libraries (environmental), but those are external to the lint gate validation and did not block thecheck-lint-policyresult.cargo fmtapplied changes; thextaskgate and the policy files are present and validated by the added command.Codex Task