🛡️ Sentinel: [CRITICAL/HIGH] Fix Cache Poisoning in CORS Reflection

[EffortlessSteven]

🚨 Severity: HIGH
💡 Vulnerability: Cache Poisoning via Dynamic CORS Reflection. When reflecting the incoming Origin header into the Access-Control-Allow-Origin response header, a Vary: Origin header was not appended. This could allow intermediate caches to serve a response intended for one origin to another.
🎯 Impact: Attackers could potentially bypass CORS policies if responses are cached by CDNs or proxies.
🔧 Fix: Appended response.headers_mut().append(header::VARY, HeaderValue::from_static("origin")); in the CORS middleware blocks handling origin reflection across both app-http and http-middleware.
✅ Verification: Ran cargo test -p app-http -p http-middleware and all tests pass.

---

PR created automatically by Jules for task 627243199119331548 started by @EffortlessSteven

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 17 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cad6d0c0-d971-43ef-90a7-c4647b382b06

📥 Commits

Reviewing files that changed from the base of the PR and between 90fd4d1 and 4746c69.

📒 Files selected for processing (3)

• .jules/sentinel.md
• crates/app-http/src/middleware/cors.rs
• crates/http-middleware/src/cors.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-fix-cors-vary-origin-627243199119331548

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Test Results

283 tests   245 ✅  11m 6s ⏱️
 25 suites   38 💤
  1 files      0 ❌

Results for commit 4746c69.