Add strict Clippy policy foundation (MSRV 1.93) and xtask lint-policy gate#435
Add strict Clippy policy foundation (MSRV 1.93) and xtask lint-policy gate#435EffortlessSteven wants to merge 1 commit intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (17)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
❌ Agents Governance Check Failed Fix the errors reported above. See AGENTS_GOVERNANCE.md for troubleshooting. |
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit a78d85a. |
Motivation
Cargo.tomlinto machine-readable, reviewable artifacts so upgrades (1.94/1.95) and exceptions are tracked and auditable.xtaskverification gate so CI/local tooling can validate MSRV alignment, lint inheritance, planned flips, and debt/allowlist correctness.Description
1.93and added a strict workspace lint block under[workspace.lints.rust]and[workspace.lints.clippy]in the rootCargo.toml.policy/clippy-lints.toml(active + planned ledger),policy/clippy-debt.toml(owned temporary exceptions),policy/no-panic-allowlist.toml(semantic panic-family receipts), andpolicy/non-rust-allowlist.toml(non-Rust surface receipts).clippy.tomlas the repository-local architecture surface for narrow disallowed methods/types/macros and created reusable templates undertemplates/rust/clippyandtemplates/rust/docs.cargo xtaskvalidation: new commandcheck-lint-policy(crates/xtask/src/commands/check_lint_policy.rs) andpolicy-reportwiring into thextaskCLI to verify required files, MSRV parity, workspace lint inheritance, no test carveouts, planned lint tracking, and debt metadata.Testing
cargo +1.93.0 fmt --checkwhich passed.cargo +1.93.0 check -p xtaskwhich compiled the xtask and supporting crates (fixed required temporary debt entry to permit build) and succeeded.cargo +1.93.0 run -p xtask -- policy-reportwhich produced a lint-policy report and returned successfully (report mode).cargo +1.93.0 run -p xtask -- check-lint-policywhich correctly failed the new blocking gate with expected findings (current rollout reports ~51 workspace members that still need[lints] workspace = true), leaving the failure surface explicit for follow-up staged PRs.Codex Task