Add org-wide Clippy policy, policy ledgers, TOML allowlists and xtask checks (MSRV 1.93)#436
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (70)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Scope Guard Summary
Change distribution:
Policy evaluation: 💡 Add a |
|
✅ Agents Governance Check Passed All agents in |
Test Results283 tests 245 ✅ 5m 27s ⏱️ Results for commit a1751b0. |
Motivation
Description
1.93and injected the strict workspace lint block under[workspace.lints.rust]and[workspace.lints.clippy]inCargo.tomland generatedtemplates/rust/clippy/Cargo.lints.strict.tomlfrom it.policy/:clippy-lints.toml(ledger + planned flips),clippy-debt.toml(debt ledger),no-panic-allowlist.toml(semantic panic allowlist), andnon-rust-allowlist.toml(non-Rust receipts), plusdocs/CLIPPY_POLICY.mdand template copies undertemplates/rust/.crates/xtask/src/commands/lint_policy.rsand wiring new commands intocrates/xtask(CheckLintPolicy,CheckNoPanicFamily,CheckFilePolicy,PolicyReport), and updated workspace members to inherit lints ([lints] workspace = true).unsafeusages with narrow#[expect(..., reason = "...")]where they implement audited safe wrappers, and copiedclippy.tomlinto the templates area for repo-specific disallowed methods.Testing
cargo +1.93.0 fmt --all(succeeded).cargo +1.93.0 run -p xtask -- check-lint-policy, which initially revealed issues and unsafe/expect formatting but after fixes the lint policy checks passed.cargo +1.93.0 run -p xtask -- check-file-policy, which failed because many non-Rust programming files (examples, frontend dist and node_modules artifacts, etc.) are not yet covered bypolicy/non-rust-allowlist.tomland therefore need explicit receipts (this is expected on first rollout).Codex Task