Skip to content

🎨 Palette: Improve screen reader support for dynamic game score#129

Open
EiJackGH wants to merge 2 commits into
mainfrom
palette/mario-game-accessibility-846035298211940693
Open

🎨 Palette: Improve screen reader support for dynamic game score#129
EiJackGH wants to merge 2 commits into
mainfrom
palette/mario-game-accessibility-846035298211940693

Conversation

@EiJackGH

@EiJackGH EiJackGH commented Apr 9, 2026

Copy link
Copy Markdown
Owner

💡 What

Added aria-live="polite" and aria-atomic="true" to the #score element in the Mario game (src/views/mario-game.njk).

🎯 Why

As the user plays the game and scores points, the #score text content changes dynamically. Without ARIA live regions, screen reader users would not be notified of these important status updates.

📸 Before/After

(Visuals remain unchanged, this is a purely semantic/accessibility update to the DOM).

♿ Accessibility

  • Implemented aria-live="polite" so screen readers will announce score changes during natural pauses in speech, rather than interrupting the user immediately.
  • Implemented aria-atomic="true" to ensure the screen reader reads the entire node content (e.g., "Score: 5") rather than just the changed digit.

PR created automatically by Jules for task 846035298211940693 started by @EiJackGH

Adds `aria-live="polite"` and `aria-atomic="true"` to the `#score` element
in `src/views/mario-game.njk` to ensure screen readers correctly and
unintrusively announce score updates to users.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Removes the standard library module `venv` from `requirements.txt`
which was causing `pip install -r requirements.txt` to fail during
the GitHub Actions CI build due to "No matching distribution found
for venv".

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant