Skip to content

🎨 Palette: Add ARIA live region to Mario game score#134

Closed
EiJackGH wants to merge 2 commits into
mainfrom
palette-mario-a11y-15562847174105512440
Closed

🎨 Palette: Add ARIA live region to Mario game score#134
EiJackGH wants to merge 2 commits into
mainfrom
palette-mario-a11y-15562847174105512440

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

What

Added aria-live="polite" and aria-atomic="true" attributes to the #score div in src/views/mario-game.njk.

Why

When playing the Mario game, the score updates dynamically as the user progresses. Without these attributes, screen readers may not announce the score updates. Adding aria-live ensures that visually impaired users receive updates on their score in a non-disruptive manner.

Before/After

(Visuals remain unchanged)

Accessibility

  • Screen Reader Support: Screen readers will now politely announce changes to the score element without interrupting the current focus. aria-atomic ensures the entire score string is read rather than just the changed digit.

PR created automatically by Jules for task 15562847174105512440 started by @EiJackGH

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant