Skip to content

🎨 Palette: Make dynamic score updates accessible to screen readers#136

Closed
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-a11y-5607166680208367396
Closed

🎨 Palette: Make dynamic score updates accessible to screen readers#136
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-a11y-5607166680208367396

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What

Added aria-live="polite" and aria-atomic="true" attributes to the #score div in src/views/mario-game.njk.

🎯 Why

In the current implementation, the score increments visually as Goombas are defeated, but screen readers are unaware of these updates. This change ensures that screen reader users receive dynamic feedback when the score changes without disrupting the game flow.

📸 Before/After

(Visuals remain unchanged, but the DOM structure is updated to support accessibility.)
Before: <div id="score">Score: 0</div>
After: <div id="score" aria-live="polite" aria-atomic="true">Score: 0</div>

♿ Accessibility

  • aria-live="polite": Informs the screen reader to announce updates at the next graceful opportunity, avoiding interruption of current speech.
  • aria-atomic="true": Ensures the screen reader announces the entire region (e.g., "Score: 1") rather than just the changed character, providing clear context.

PR created automatically by Jules for task 5607166680208367396 started by @EiJackGH

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant