Skip to content

🎨 Palette: Add keyboard controls hint and a11y score updates to Mario game#138

Closed
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-ux-3782868735741987336
Closed

🎨 Palette: Add keyboard controls hint and a11y score updates to Mario game#138
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-ux-3782868735741987336

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What:

  • Added a visual keyboard shortcut hint ("Jump: Space or ↑") to the Mario game overlay.
  • Added aria-live="polite" and aria-atomic="true" to the score counter.
  • Made the score font bolder for better readability.
  • Cleaned up the requirements.txt file by removing the broken venv entry to ensure smooth local test runs and CI checks.

🎯 Why:

  • Intuitiveness: New players immediately know which keys to press without trial and error.
  • Accessibility (Score): Screen reader users will now be politely notified as their score increments dynamically during gameplay.
  • Project Health: Removing venv from the requirements file enables standard pip install -r requirements.txt commands to work without throwing errors.

📸 Before/After:

Before: Only the score was displayed, with no indication of controls.
After: A subtle, semi-transparent hint box sits below the score, providing clear gameplay instructions without obstructing the screen.

♿ Accessibility:

  • The score dynamically updates using ARIA live regions.
  • The control hint is visible to sighted users and automatically readable by screen readers as standard HTML content (no aria-hidden tricks used).

PR created automatically by Jules for task 3782868735741987336 started by @EiJackGH

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant