Skip to content

🎨 Palette: Make Mario game accessible and add keyboard instructions#159

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-a11y-14649692834381255217
Open

🎨 Palette: Make Mario game accessible and add keyboard instructions#159
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-a11y-14649692834381255217

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What

Added aria-live="polite" and aria-atomic="true" to the score element so screen readers can announce it dynamically. Also added explicit, visible instructional text for keyboard controls underneath the score.

🎯 Why

Screen reader users would not be notified of the score updating dynamically without ARIA attributes. Furthermore, without visual cues, players have to guess the keybindings to play the game, violating a fundamental heuristic for interactive game UI.

📸 Before/After

(Visuals provided via standard Playwright checks)
The UI now correctly features "Press Space or ↑ to jump" immediately visible beneath the standard "Score: X" indicator.

♿ Accessibility

  • Ensured dynamic text updates map to screen readers
  • Improved user onboarding with intuitive visual feedback

PR created automatically by Jules for task 14649692834381255217 started by @EiJackGH

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant