Skip to content

🎨 Palette: Improve accessibility and instructions for Mario Game #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EiJackGH wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Improve accessibility and instructions for Mario Game #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@
## 2025-03-23 - Game Key Scrolling
**Learning:** Browsers natively scroll the page when users press Space or Arrow keys. When building a web-based game, this creates a frustrating UX where the game viewport jumps around while playing.
**Action:** Always call `e.preventDefault()` on keydown events for typical game controls ("Space", "ArrowUp", etc.) when the focus is on a game container or the body.
## 2026-05-28 - Interactive Element Instructions in Nunjucks
**Learning:** For game components rendered directly in templates (like `mario-game.njk`) where the keyboard event listeners map to native browser navigation keys (Space/Arrow keys), users often don't instinctively know the custom bindings.
**Action:** Always provide explicit, visible instructional text that tells the user exactly which keys to press, and use CSS (e.g., `pointer-events: none`, `text-shadow`) to ensure the text does not interfere with the game canvas interactions and is legible against background sprites.
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
numpy
pandas
requests
venv
15 changes: 14 additions & 1 deletion src/views/mario-game.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,26 @@
font-size: 20px;
font-family: Arial;
}

#instructions {
position: absolute;
bottom: 60px;
width: 100%;
text-align: center;
color: white;
font-size: 16px;
font-family: Arial;
text-shadow: 1px 1px 2px black;
pointer-events: none;
}
</style>
</head>

<body>

<div id="game">
<div id="score">Score: 0</div>
<div id="score" aria-live="polite" aria-atomic="true">Score: 0</div>
<div id="instructions">Press Space or Up Arrow to jump</div>
<div id="mario"></div>
<div class="ground"></div>
</div>
Expand Down
Loading