Skip to content

🎨 Palette: Improve mario game UX and accessibility#205

Open
EiJackGH wants to merge 2 commits into
mainfrom
palette-mario-game-ux-1115560114099330141
Open

🎨 Palette: Improve mario game UX and accessibility#205
EiJackGH wants to merge 2 commits into
mainfrom
palette-mario-game-ux-1115560114099330141

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What

Added explicit instructional text telling the user how to jump ("Press Space or Up Arrow to jump!") and added aria-live="polite" to the score text so it announces to screen readers.

🎯 Why

Without explicit instructions, players (especially new ones) are left guessing which keys work for interaction, which leads to confusion. Additionally, as the score updates dynamically when goombas are avoided, screen readers would not naturally pick up the change, creating an accessibility barrier.

📸 Before/After

(Verified via Playwright screenshot locally)
Before: Only the score is shown.
After: Instructional text with a slight opacity (0.8) sits neatly under the score, maintaining the retro vibe without distracting from gameplay.

♿ Accessibility

  • Added aria-live="polite" and aria-atomic="true" to #score to ensure the dynamic score changes are announced to assistive technologies without aggressively interrupting the user.
  • Explicit instructions remove the cognitive load of guessing keyboard controls.

PR created automatically by Jules for task 1115560114099330141 started by @EiJackGH

- Added explicit instructional text telling users how to jump.
- Added aria-live attributes to the score element for screen readers.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…me, and fix CI

- Added explicit instructional text telling users how to jump.
- Added aria-live attributes to the score element for screen readers.
- Fixed CI check suite failure by permanently removing the `venv` module from `requirements.txt`.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant