Skip to content

🎨 Palette: [UX improvement] Add keyboard instructions and ARIA labels to Mario Game#208

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-game-a11y-instructions-18117282532858227309
Open

🎨 Palette: [UX improvement] Add keyboard instructions and ARIA labels to Mario Game#208
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-game-a11y-instructions-18117282532858227309

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What: Added aria-live="polite" to the score container so it announces cleanly to screen readers, and added explicit instructions indicating that "Space or Up Arrow" are needed to jump.
🎯 Why: Games with custom key bindings can leave users frustrated if they don't know the controls. Furthermore, screen readers need explicit ARIA hints to announce dynamic score updates without repeating static instructions.
📸 Before/After: (See Playwright verification screenshot in PR attachments)
♿ Accessibility:

  • Screen readers will now announce the score gracefully when it increments (thanks to aria-live="polite" and aria-atomic="true").
  • Avoided placing the static keyboard hints inside the aria-live region, preserving clarity for screen reader users.

PR created automatically by Jules for task 18117282532858227309 started by @EiJackGH

* Adds aria-live="polite" and aria-atomic="true" to the score container to announce updates.
* Adds a visible instructional text element guiding users to use Space or Up Arrow.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant