🎨 Palette: Add explicit game controls and aria-live score#221
Conversation
💡 What: Added an instructional text div to the Mario game view explaining the controls ("Press Space or Up Arrow to jump") and added `aria-live="polite"` and `aria-atomic="true"` to the dynamic score div.
🎯 Why: Custom keyboard event bindings for games require explicit instructions so users know how to play. Adding `aria-live` to the score ensures screen reader users receive dynamic updates. Keeping the static instructional text out of the `aria-live` region prevents screen readers from needlessly repeating the instructions every time the score updates.
♿ Accessibility: Improved screen reader accessibility for the score counter and clarified controls.
📸 Before/After: See PR media.
Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎨 Palette: Add explicit game controls and aria-live score
💡 What: Added an instructional text div to the Mario game view explaining the controls ("Press Space or Up Arrow to jump") and added
aria-live="polite"andaria-atomic="true"to the dynamic score div.🎯 Why: Custom keyboard event bindings for games require explicit instructions so users know how to play. Adding
aria-liveto the score ensures screen reader users receive dynamic updates. Keeping the static instructional text out of thearia-liveregion prevents screen readers from needlessly repeating the instructions every time the score updates.♿ Accessibility: Improved screen reader accessibility for the score counter and clarified controls.
📸 Before/After: See PR media.
PR created automatically by Jules for task 12657445712183124581 started by @EiJackGH