Skip to content

🎨 Palette: Add game instructions and screen reader support for score#222

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette-ux-mario-game-11859134662329315405
Open

🎨 Palette: Add game instructions and screen reader support for score#222
EiJackGH wants to merge 1 commit into
mainfrom
palette-ux-mario-game-11859134662329315405

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What: Added visible controls instructions to the top right of the Mario game view and improved screen reader accessibility for the score counter.

🎯 Why: Users need to know how to interact with the game. Moreover, screen reader users were previously subjected to hearing "Score:" read out entirely every time the score number incremented. Separating the static label from the dynamic number inside the aria-live region creates a significantly better audio UX.

Accessibility: Added aria-live="polite" and aria-atomic="true" to just the score number value span, improving dynamic content announcements. Added a journal entry to .Jules/palette.md to reflect this learning.


PR created automatically by Jules for task 11859134662329315405 started by @EiJackGH

- Added visible keyboard instructions "Controls: Space / Up Arrow"
- Separated the static text "Score:" from the dynamically updating score value.
- Wrapped dynamic score inside a span with aria-live="polite" and aria-atomic="true" so screen readers don't unnecessarily repeat "Score".
- Logged learning about aria-live into .Jules/palette.md

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant