Skip to content

🎨 Palette: Enhance Mario Game UX and Accessibility #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EiJackGH wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Enhance Mario Game UX and Accessibility #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@
## 2025-03-23 - Game Key Scrolling
**Learning:** Browsers natively scroll the page when users press Space or Arrow keys. When building a web-based game, this creates a frustrating UX where the game viewport jumps around while playing.
**Action:** Always call `e.preventDefault()` on keydown events for typical game controls ("Space", "ArrowUp", etc.) when the focus is on a game container or the body.
## 2026-07-14 - Adding explicit instructions to interactive canvas
**Learning:** When building interactive HTML5 widgets or games with custom keyboard event bindings that aren't native UI controls, users and screen readers lack affordances to know how to interact. Also, floating UI instructions must not block clicks.
**Action:** Always provide explicit, visible instructional text for custom controls, separate static labels from aria-live dynamic content, and use `pointer-events: none` on floating instruction overlays.
23 changes: 19 additions & 4 deletions src/views/mario-game.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,29 +44,44 @@
background: #2ecc71;
}

#score {
#score-container {
position: absolute;
top: 10px;
left: 10px;
color: white;
font-size: 20px;
font-family: Arial;
}

#instructions {
position: absolute;
bottom: 60px;
left: 50%;
transform: translateX(-50%);
color: white;
font-size: 16px;
font-family: Arial;
background: rgba(0, 0, 0, 0.5);
padding: 5px 10px;
border-radius: 5px;
pointer-events: none;
}
</style>
</head>

<body>

<div id="game">
<div id="score">Score: 0</div>
<div id="score-container">Score: <span id="score-val" aria-live="polite" aria-atomic="true">0</span></div>
<div id="instructions">Press Space or Up Arrow to jump</div>
<div id="mario"></div>
<div class="ground"></div>
</div>

<script>
const mario = document.getElementById("mario");
const game = document.getElementById("game");
const scoreText = document.getElementById("score");
const scoreVal = document.getElementById("score-val");

let jumping = false;
let score = 0;
Expand Down Expand Up @@ -118,7 +133,7 @@
clearInterval(move);
goomba.remove();
score++;
scoreText.innerText = "Score: " + score;
scoreVal.innerText = score;
} else {
position -= 6;
goomba.style.left = position + "px";
Expand Down