Skip to content

Fix multi commit CI job #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tomt1664 wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix multi commit CI job #1590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffb041d
broaden the CMake guard for simplicity to also match Clang on any pla…
tomt1664 Aug 27, 2026
8d5fc2c
temporary comment change to test multiple commit CI
tomt1664 Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ target_link_libraries(elementssimplicity
core_interface
)

# macOS Apple Clang is stricter than Linux GCC on this vendored code
if(APPLE)
# Clang is stricter than Linux GCC on this vendored code
if(CMAKE_C_COMPILER_ID MATCHES "Clang")
target_compile_options(elementssimplicity PRIVATE
-Wno-error=conditional-uninitialized
-Wno-error=implicit-fallthrough
Expand Down
Loading