Repository navigation
Validate Linux bridge startup deadline - #2
Merged
Merged
Conversation
initializeLinuxNetworkBridge checked for both socat sockets five times, with sleeps of 0, 100, 200 and 300 ms between checks, so a healthy socat that takes 0.9 s to bind failed every start. Wait until a five-second deadline instead, polling at most every 100 ms within the remaining budget, and keep the timeout's process cleanup. The new tests start real socat behind a delayed wrapper. They fail against main and pass with this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 21, 2026
EliasCodeFI
marked this pull request as ready for review
October 21, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the reviewed Linux bridge-startup deadline change on the fork's supported runners before opening its upstream pull request.
The source is the existing EliasCodeFI commit
ba9838d38a5dde579389291aa5de18448b0e0b42. Its production and regression-test bytes match the accepted independent review. The change replaces the fixed readiness-attempt limit with an elapsed-time deadline and retains timeout cleanup.The local host cannot start the default seccomp helper because its nested user-namespace setup is denied. Local focused checks and review do not establish that coverage. This pull request runs the actual fork workflows to resolve that gap; no release publication is requested.