Persist changed-files expansion state per thread#37
Open
Marve10s wants to merge 3 commits intoEmanuele-web04:mainfrom
Open
Persist changed-files expansion state per thread#37Marve10s wants to merge 3 commits intoEmanuele-web04:mainfrom
Marve10s wants to merge 3 commits intoEmanuele-web04:mainfrom
Conversation
…-files-expansion # Conflicts: # apps/web/src/components/chat/ChatTranscriptPane.tsx # apps/web/src/components/chat/MessagesTimeline.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
MessagesTimelinecomponent state.Why
The changed-files tree reset to expanded whenever the thread view unmounted and mounted again. That happened because the expansion map lived inside
MessagesTimelineas local React state.Notes
t3code#1858behavior to DPcode's current store structure.Validation
bun fmtbun lintbun typecheckbun run --cwd apps/web test --run src/store.test.ts src/components/chat/MessagesTimeline.test.tsx