chore: tidy leftovers from the API data-layer switch - #7
Merged
Merged
Conversation
- Drop the unused avatarUrl field from SessionUser; it was mapped from GET /me but never rendered. - Generate the default API client without a base URL (baseUrl: false). It previously hardcoded the prod Function App, so an SDK call that forgot `client:` would have silently hit production. - ESLint no-restricted-imports blocks importing api/client.gen outside src/lib/api-client.ts, enforcing the convention the wrapper documents. - Mark docs/PHASED_IMPLEMENTATION.md as historical; it still describes the retired auth-function and Octokit data layer. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DeJbLw7zjGXxSnHX3pAdj1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanups left over from the step 4 switch to the ATK API (#2).
SessionUser.avatarUrlwas mapped fromGET /mebut never rendered anywhere. Removed, along with the test fixtures that set it. If we want an avatar in the header later, the principal still carries it.src/lib/api/client.gen.tsis now generated withbaseUrl: false. It used to hardcodefunc-atk-prod, so any SDK call that forgot to passclient:would have silently gone to production; now it fails on a relative URL instead.no-restricted-importsrule blocks importingapi/client.genoutsidesrc/lib/api-client.ts, enforcing the convention the wrapper's doc comment andopenapi-ts.config.tsalready stated.docs/PHASED_IMPLEMENTATION.mdstill describes the in-repoauth-functionand an Octokit data layer. Added a "historical" banner pointing atPROJECT_OVERVIEW.mdand reworded the link indocs/deployment.md.No user-visible change.
pnpm lint,pnpm typecheck, andpnpm test(29 files, 295 tests) pass. The same generator/lint change is going into the CLI repo in parallel.🤖 Generated with Claude Code
https://claude.ai/code/session_01DeJbLw7zjGXxSnHX3pAdj1