Open
Conversation
added 4 commits
March 20, 2026 10:51
jansentjeu
requested changes
Apr 3, 2026
Collaborator
jansentjeu
left a comment
jansentjeu
left a comment
There was a problem hiding this comment.
Also set target branch to develop
| public function __construct( | ||
| Context $context, | ||
| Registry $registry, | ||
| protected string $idField = 'key', |
Collaborator
There was a problem hiding this comment.
Is this the language ID data key not always key? Why do we need this configurable?
It is only used in src/Model/Api/Response/Catalog/LanguageResponse.php, right?
Comment on lines
+46
to
+47
| 'label' => $language['name'], | ||
| 'value' => $language['key'] |
Collaborator
There was a problem hiding this comment.
Why do you create LanguageType objects when you don't use the functions of it?
$language is a type of the LanguageType object, the reason to do this is that you can retrieve data with the getters.
$language->getName()
$language->getLanguageId()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for configurable language settings in the TweakwiseJs module.
This pull requests adds two settings
For the catalog language (based on available languages in tweakwise). This determines the translations of the filters.
The ui language. This determines the language of the ui interface (add to cart button, etc)
How to test