Remove redundant adapter methods for get/setBiome#2984
Open
Dreeam-qwq wants to merge 1 commit into
Open
Conversation
Collaborator
|
the bukkit api does not (did not?) support setting custom biomes. on those versions, the output of BukkitAdapter.adapt can't be used. i haven't kept up with upstream changes (barely with EH stuff), but given the targeting matrix here (spigot and paper back multiple versions), i wouldn't be so quick to consider this pointless. |
Member
|
When I last audited our registry hacks last year, I found that biomes still had issues on Spigot in versions that we still do currently support. I've not had a chance to take a look at versions since then as Spigot for 26.1+ is rather unstable on my machine, but we will need to keep these adapters either until all versions which don't work properly are unsupported, or if we ever chose to drop Spigot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup redundant adapter methods for get/setBiome. These adapter methods were added many years ago, and for now, there is no point to keep use them; we can just use bukkit api instead.