Skip to content

Remove deprecated BiomeData API #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
me4502 merged 1 commit into from
Jul 7, 2026
Merged

Remove deprecated BiomeData API #2986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions verification/src/changes/accepted-core-public-api-changes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,47 @@
"CONSTRUCTOR_REMOVED"
]
}
],
"Removal of deprecated API for WorldEdit 8": [
{
"type": "com.sk89q.worldedit.world.biome.BiomeData",
"member": "Class com.sk89q.worldedit.world.biome.BiomeData",
"changes": [
"CLASS_REMOVED",
"ANNOTATION_REMOVED"
]
},
{
"type": "com.sk89q.worldedit.world.biome.BiomeData",
"member": "Method com.sk89q.worldedit.world.biome.BiomeData.getName()",
"changes": [
"METHOD_REMOVED",
"ANNOTATION_REMOVED"
]
},
{
"type": "com.sk89q.worldedit.world.biome.Biomes",
"member": "Class com.sk89q.worldedit.world.biome.Biomes",
"changes": [
"CLASS_REMOVED",
"ANNOTATION_REMOVED"
]
},
{
"type": "com.sk89q.worldedit.world.biome.Biomes",
"member": "Method com.sk89q.worldedit.world.biome.Biomes.findBiomeByName(java.util.Collection,java.lang.String,com.sk89q.worldedit.world.registry.BiomeRegistry)",
"changes": [
"METHOD_REMOVED",
"ANNOTATION_REMOVED"
]
},
{
"type": "com.sk89q.worldedit.world.registry.BiomeRegistry",
"member": "Method com.sk89q.worldedit.world.registry.BiomeRegistry.getData(com.sk89q.worldedit.world.biome.BiomeType)",
"changes": [
"METHOD_REMOVED",
"ANNOTATION_REMOVED"
]
}
]
}
14 changes: 0 additions & 14 deletions worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitBiomeRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,8 @@
import com.sk89q.worldedit.util.formatting.text.Component;
import com.sk89q.worldedit.util.formatting.text.TranslatableComponent;
import com.sk89q.worldedit.util.translation.TranslationManager;
import com.sk89q.worldedit.world.biome.BiomeData;
import com.sk89q.worldedit.world.biome.BiomeType;
import com.sk89q.worldedit.world.registry.BiomeRegistry;
import org.bukkit.block.Biome;

import javax.annotation.Nullable;

/**
* A biome registry for Bukkit.
Expand All @@ -43,14 +39,4 @@ public Component getRichName(BiomeType biomeType) {
TranslationManager.makeTranslationKey("biome", biomeType.id())
);
}

@SuppressWarnings({ "removal" })
@Deprecated
@Nullable
@Override
public BiomeData getData(BiomeType biome) {
final Biome bukkitBiome = BukkitAdapter.adapt(biome);
return bukkitBiome == null ? null : bukkitBiome::name;
}

}
28 changes: 0 additions & 28 deletions worldedit-core-mc/src/main/java/com/sk89q/worldedit/coremc/internal/CoreMcBiomeRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

import com.sk89q.worldedit.util.formatting.text.Component;
import com.sk89q.worldedit.util.formatting.text.TranslatableComponent;
import com.sk89q.worldedit.world.biome.BiomeData;
import com.sk89q.worldedit.world.biome.BiomeType;
import com.sk89q.worldedit.world.registry.BiomeRegistry;
import net.minecraft.resources.Identifier;
Expand All @@ -36,31 +35,4 @@ public final class CoreMcBiomeRegistry implements BiomeRegistry {
public Component getRichName(BiomeType biomeType) {
return TranslatableComponent.of(Util.makeDescriptionId("biome", Identifier.parse(biomeType.id())));
}

@Deprecated
@Override
public BiomeData getData(BiomeType biome) {
return new CoreMcBiomeData(biome);
}

@Deprecated
private static final class CoreMcBiomeData implements BiomeData {
private final BiomeType biome;

/**
* Create a new instance.
*
* @param biome the base biome
*/
private CoreMcBiomeData(BiomeType biome) {
this.biome = biome;
}

@SuppressWarnings("deprecation")
@Override
public String getName() {
return biome.id();
}
}

}
43 changes: 0 additions & 43 deletions worldedit-core/src/main/java/com/sk89q/worldedit/world/biome/BiomeData.java
View file
Open in desktop

This file was deleted.

60 changes: 0 additions & 60 deletions worldedit-core/src/main/java/com/sk89q/worldedit/world/biome/BiomeName.java
View file
Open in desktop

This file was deleted.

75 changes: 0 additions & 75 deletions worldedit-core/src/main/java/com/sk89q/worldedit/world/biome/Biomes.java
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BiomeRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,8 @@
package com.sk89q.worldedit.world.registry;

import com.sk89q.worldedit.util.formatting.text.Component;
import com.sk89q.worldedit.world.biome.BiomeData;
import com.sk89q.worldedit.world.biome.BiomeType;

import javax.annotation.Nullable;

/**
* Provides information on biomes.
*/
Expand All @@ -38,16 +35,4 @@ public interface BiomeRegistry {
*/
Component getRichName(BiomeType biomeType);

/**
* Get data about a biome.
*
* @param biome the biome
* @return a data object or null if information is not known
* @deprecated This method no longer returns any useful information.
* Use {@link #getRichName(BiomeType)} for the name of the biome.
*/
@Deprecated
@Nullable
BiomeData getData(BiomeType biome);

}
13 changes: 0 additions & 13 deletions worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/NullBiomeRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,8 @@
import com.sk89q.worldedit.util.formatting.text.Component;
import com.sk89q.worldedit.util.formatting.text.TranslatableComponent;
import com.sk89q.worldedit.util.translation.TranslationManager;
import com.sk89q.worldedit.world.biome.BiomeData;
import com.sk89q.worldedit.world.biome.BiomeType;

import javax.annotation.Nullable;

/**
* A biome registry that knows nothing.
*/
Expand All @@ -44,14 +41,4 @@ public Component getRichName(BiomeType biomeType) {
TranslationManager.makeTranslationKey("biome", biomeType.id())
);
}

// Suppress InlineMeSuggester: This method cannot be made final due to backwards compatibility
@SuppressWarnings("InlineMeSuggester")
@Deprecated
@Nullable
@Override
public BiomeData getData(BiomeType biome) {
return null;
}

}
33 changes: 0 additions & 33 deletions worldedit-sponge/src/main/java/com/sk89q/worldedit/sponge/SpongeBiomeRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,7 @@
import com.sk89q.worldedit.util.formatting.text.Component;
import com.sk89q.worldedit.util.formatting.text.TranslatableComponent;
import com.sk89q.worldedit.util.translation.TranslationManager;
import com.sk89q.worldedit.world.biome.BiomeData;
import com.sk89q.worldedit.world.registry.BiomeRegistry;
import org.spongepowered.api.registry.RegistryReference;
import org.spongepowered.api.world.biome.Biome;

import javax.annotation.Nullable;

/**
* Provides access to biome data in Sponge.
Expand All @@ -40,32 +35,4 @@ public Component getRichName(com.sk89q.worldedit.world.biome.BiomeType biomeType
TranslationManager.makeTranslationKey("biome", biomeType.id())
);
}

@Deprecated
@Nullable
@Override
public BiomeData getData(com.sk89q.worldedit.world.biome.BiomeType biome) {
return new SpongeBiomeData(SpongeAdapter.adapt(biome));
}

@Deprecated
private static class SpongeBiomeData implements BiomeData {
private final RegistryReference<Biome> biome;

/**
* Create a new instance.
*
* @param biome the base biome
*/
private SpongeBiomeData(RegistryReference<Biome> biome) {
this.biome = biome;
}

@SuppressWarnings("deprecation")
@Override
public String getName() {
return biome.location().asString();
}
}

}
Loading