feat(engineering): add interactive PR review skill - #461
Merged
Conversation
Deploying allagents with
|
| Latest commit: |
60fd169
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e5911bd2.allagents.pages.dev |
| Branch Preview URL: | https://feat-pr-interactive-review.allagents.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewers can now turn structured pull request findings into a reusable local workspace with business context, concrete failure scenarios, exact reviewed-commit links, and local discussion. The skill uses an existing review skill when one is available, while keeping review scope, severity, validation, and deduplication outside the presentation layer.
Design decisions
Safety
The renderer escapes untrusted values, validates paths and identifiers, pins source links to the reviewed commit, rejects cross-origin writes, and bounds request bodies while streaming. Comment updates use atomic writes, and the server does not expose arbitrary filesystem paths.
Validation
bun test tests/unit/plugins/pr-interactive-review.test.ts— 9 passed, 59 assertionsbunx tsc -p plugins/engineering/skills/pr-interactive-review/scripts/tsconfig.json— passedclaude plugin validate plugins/engineering --strict— passed