Skip to content

Define how to run tests #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
furtib wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Define how to run tests #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5de2373
Define how to run tests
furtib Apr 8, 2026
91f8ea4
Define micromamba as defacto environment manager
furtib May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .ci/micromamba/dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ dependencies:
- pytest
- pylint
- pycodestyle
- buildifier
- clang
- clang-tools
- bazel=6
- bazel=7
- pip:
- codechecker==6.25
13 changes: 12 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,15 @@ test/test.sh | Functional and unit test runner
Submitting a patch and testing
-------

Before submitting any changes please make sure all tests and checks are passed, pylint doesn't show warnings on new code, and fill out the Pull Request template. If you are a new contributor, and the template is confusing, feel free to submit the PR and we will help you iron it out! On how to run or add a new test, please see [test/README.md](test/README.md).
Before submitting any changes please make sure all tests and checks are passed.
Copy link
Copy Markdown
Collaborator

@nettle nettle Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure, before running anything we must crealy describe how to initialize the environment.
See Development Environment above


You must run the following tests locally:
* `pylint .`
* `bazel test //...`
* `pytest test`


On how to run or add a new test, please see [test/README.md](test/README.md).


Finally, fill out the Pull Request template. If you are a new contributor, and the template is confusing, feel free to submit the PR and we will help you iron it out!
16 changes: 16 additions & 0 deletions run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/usr/bin/env bash

cleanup() {
# Very important
# reactivation of the mamba environment is not possible if skipped
bazel clean
micromamba deactivate
}

trap cleanup EXIT

source ./.ci/micromamba/init.sh
Copy link
Copy Markdown
Collaborator

@nettle nettle May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had previous micromamba dev env in .ci/micromamba/micromamba
so init immediately failed with:

critical libmamba Non-conda folder exists at prefix - aborting.

I had to remove it completely to unlock.
So... we should work on how to make it robust


pylint .
bazel test //...
pytest test
Comment on lines +14 to +16
Copy link
Copy Markdown
Collaborator

@nettle nettle May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These steps need some log/diagnostic messages to just indicate what is going on on the screen. Something like:

echo "Running pylint"
pylint .
...

Loading