Add comprehensive BuildSettings types from Apple docs#49
Merged
Conversation
Expand the BuildSettings interface with a large, organized set of Xcode build setting keys (SDK, Architectures, Deployment, Versioning, Product, Info.plist keys, Code Signing, Swift, Clang, GCC, Linking, warnings, and more), adding precise types, enums and documentation comments for each section. Also remove a couple of transient @ts-expect-error comments in XCBuildConfiguration when resolving settings so the code relies on the improved typings. These changes increase TypeScript coverage for Xcode settings and clean up previously suppressed type errors; review callers for potential typing adjustments if they depended on looser types.
EvanBacon
force-pushed
the
@evanbacon/build-settings-from-docs
branch
from
fa8a314 to
aaa3f8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuildSettingsinterface insrc/json/types.tsbased on Apple's Build Settings Reference@ts-expect-errordirectives inXCBuildConfiguration.tsTest plan
bun run buildcompiles successfully🤖 Generated with Claude Code