Repository navigation
fix: recache preserves file modes - #16
Merged
Merged
Conversation
`undev` and `repair` recached every file as 0644, dropping the executable bit on plugin scripts: a script called directly then exits 126. The copy now keeps the source file's permissions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016sNiMarQfbcHRWLuevWarY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undevandrepairrecached every file as0644(internal/cache/recache.go), dropping the executable bit on plugin scripts. A script invoked directly (e.g.scripts/pr-state.shof a skill) then exits 126 « Permission denied »; hooks went unnoticed because they run throughbash <script>. The copy now keeps the source mode, removing any stale destination file first so a read-only file doesn't block a re-copy.New E2E test: dev → undev keeps a
0755script executable (fails without the fix).🤖 Generated with Claude Code
https://claude.ai/code/session_016sNiMarQfbcHRWLuevWarY