Repository navigation
fix(e2e): deploy provider via local.xpkg.deploy instead of an HTTP registry - #12
Merged
Merged
Conversation
…gistry
Crossplane 2.3+ no longer pulls packages over plain HTTP, so the in-cluster
registry used by the e2e tests made the Provider stay Installed=False
("server gave HTTP response to HTTPS client"). Port upstream
crossplane-contrib#328: bump the build submodule, install the
package through the shared local.xpkg.deploy target, and build xpkgs with
the crossplane CLI.
Crossplane stays on the latest stable chart by default;
CROSSPLANE_HELM_CHART_VERSION pins it when needed.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L6Yfw15zmcdoVmbnW1G87w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pourquoi
Les e2e de la CI échouent sur toutes les branches depuis juin (dernier run vert le 04/05) :
timed out waiting for the condition on providers/provider-sql.Le script installe la dernière Crossplane stable, et c'est voulu. Or depuis la 2.3, Crossplane ne tire plus un paquet d'un registry en HTTP. Le registry que les e2e déployaient dans le cluster laissait donc le Provider bloqué à
Installed=False:Crossplane ne propose aucune option pour autoriser un registry non sécurisé. Il n'accepte qu'un bundle de CA supplémentaire (
CA_BUNDLE_PATH).Quoi
Cette PR reprend la PR amont crossplane-contrib#328 :
build/passe à la version de l'amont.make local.xpkg.deploy.provider.provider-sql, qui charge le paquet dans le cache de Crossplane. Le registry, le port-forward etUSE_OCIdisparaissent.up, parce que le nouveaubuild/l'exige.CROSSPLANE_HELM_CHART_VERSIONouCROSSPLANE_HELM_CHANNELpermettent d'épingler au besoin.QUICK_TESTarrive avec la PR amont.Seuls les blocs de la PR crossplane-contrib#328 ont été portés. Les tests postgres et mariadb propres au fork restent inchangés.
Validation
make build && make e2e USE_HELM=trueen local avec Crossplane 2.4.2 donneintegration tests passed. Sur master, le même run échoue avec l'erreur ci-dessus.🤖 Generated with Claude Code
https://claude.ai/code/session_01L6Yfw15zmcdoVmbnW1G87w